Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimsuggest: fix #96 ; enabled via --partialRecompilation since some cases cause crashes #9757

Merged
merged 3 commits into from
Nov 20, 2018

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Nov 19, 2018

/cc @Araq
this reopens #9715 as requested by @Araq but hides the feature under --partialRecompilation so only it's only enabled for users who want to try it out
reference:
this comment from @Araq #9721 (comment)

I liked your previous solution much better and the crashes could have been fixed, I think. The ModuleGraph can have multiple entry points, in theory there is not much to it.

description

There is some support so that you can throw random .nim files which are not part of myproject at Nimsuggest too, but usually the query refer to modules/files that are part of myproject.

this wasn't true until this PR
it's a very useful feature that allows you to handle nim files not covered by your initial project.nim

caveat

same caveat as mentioned in #9715 (comment) applies

note

tried to reopen #9715 using instructions in https://gist.github.com/robertpainsi/2c42c15f1ce6dab03a0675348edd4e2c but git push -f origin 70aa9613371081d52dfaba90fa12d5532b3e1ae1:pr_nimsuggest_fix_96 failed because I don't have credentials it seems

@timotheecour timotheecour changed the title Pr nimsuggest fix 96 nimsuggest: fix #96 ; enabled via --partialRecompilation since some cases cause crashes Nov 19, 2018
@timotheecour timotheecour requested a review from Araq November 19, 2018 20:18
@Araq
Copy link
Member

Araq commented Nov 20, 2018

I prefer to fix the most pressing crashes and to avoid yet another flag.

@timotheecour
Copy link
Member Author

timotheecour commented Nov 20, 2018

done PTAL (reverted the hiding under a new flag)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

project file update doesn't work
2 participants