-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use value-initialization in C++ to gracefully handle non-POD types #9603
Conversation
Completely necessary for any serious interaction with c++ code like we are doing with NimTorch. |
Nice, lately CI seems to be working nicely as intended! Nice catches. |
This would probably be necessary to support C++ destructors in seq status-im/nim-ttmath#10 Otherwise Clang (but not GCC) complains about: |
@mratsim I'll have a look at sequences/refs afterwards, but they might be more painful since much of them is implemented in the stdlib and not generic :/ |
This pull request has been automatically marked as stale because it has not had recent activity. If you think it is still a valid PR, please rebase it on the latest devel; otherwise it will be closed. Thank you for your contributions. |
I think |
This pull request has been automatically marked as stale because it has not had recent activity. If you think it is still a valid PR, please rebase it on the latest devel; otherwise it will be closed. Thank you for your contributions. |
Locals of types containing imported non-POD members currently get zeroed, leaving them in an invalid state. This replaces zeroing with value-initialization when in C++ mode.