Stricter checks for typedesc #8657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metagn
changed the title
|
Can't we just put an error message and that says: const Foo=int # Error: use "type Foo = int" insteadSpecial casing In the VM, |
| """ | ||
|
|
||
| const a: typedesc = typedesc[int] | ||
| echo a is typedesc[int] |
There was a problem hiding this comment.
if you're gonna error on line 6, why have line 7? (+ same in other files)
There was a problem hiding this comment.
Sanity check? I copied existing tests
There was a problem hiding this comment.
why is that a sanity check, if it won't even get compiled?
seems like you could put whatever there instead...
maybe existing tests could be updated too
|
I'm not eligible to fix the test failures, so I'm gonna close the PR and not abandon it and make everyone wait forever, if anyone wants to take over they can start another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8610, fixes #8654