addresses issue #8391 show runtime context on some failed operations #8393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Jul 22, 2018
lib/pure/os.nim
Outdated
| @@ -1005,7 +1005,7 @@ proc existsOrCreateDir*(dir: string): bool {.rtl, extern: "nos$1", | |||
| if result: | |||
| # path already exists - need to check that it is indeed a directory | |||
| if not existsDir(dir): | |||
| raise newException(IOError, "Failed to create the directory") | |||
| raise newException(IOError, "Failed to create '"& dir & "'") | |||
timotheecour
force-pushed
the
pr_os_error_show_context_fix_8391
branch
from
fd33941
to
ceff006
Compare
timotheecour
force-pushed
the
pr_os_error_show_context_fix_8391
branch
from
ceff006
to
64cf412
Compare
|
PTAL |
timotheecour
added a commit
to timotheecour/Nim
that referenced
this pull request
Jul 23, 2018
timotheecour
added a commit
to timotheecour/Nim
that referenced
this pull request
Jul 23, 2018
timotheecour
added a commit
to timotheecour/Nim
that referenced
this pull request
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.