Fix strformat neg zero #7954
Merged
Fix strformat neg zero #7954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Varriount
requested changes
Jun 4, 2018
lib/pure/strformat.nim
Outdated
| if value == 0.0: | ||
| if 1.0 / value == Inf: | ||
| # only add the sign if value != negZero | ||
| f = spec.sign & f |
There was a problem hiding this comment.
Could you use insert instead, to modify 'f' in place? It would be nice to reduce the number of temporary string allocations made in this procedure.
There was a problem hiding this comment.
There are other places where we could use insert instead of string concatenation, but i limit the change strictly to the area i want to fix (no + in front of negative zero).
Personally i don't like inplace mutations, therefore I will not produce PR's to change other places in strformat to use inplace mutations.
There was a problem hiding this comment.
It doesn't matter if you like them or not, they are faster and this is a "standard library" where everybody benefits from faster code.
Varriount
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only add explicitly requested sign if value != -0.0 (neg zero)
see issue #7923