fixes #7906, array and openarray arg vs. ptr/ref generic #7909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Jun 4, 2018
compiler/sem.nim
Outdated
| # this will trigger an error later: | ||
| if result.isNil or result == a: return x | ||
| if result == b: return y | ||
| if k != tyNone: | ||
| # bug #7906 | ||
| if k != tyNone and x.kind != tyGenericInst: |
There was a problem hiding this comment.
Please add a comment here explaining your reasoning. It seems fishy, why is tyGenericInst harmful here?
There was a problem hiding this comment.
I will add a comment.
the reason is
type
GenericObject[T] = object
GenericRefObject[T] = ref object
var a = GenericRefObject[int] # tyGenericInst of ref object
var b = new(ref GenericObject[int]) # tyRef of tyGenericInstfrom user perpective, a and b should be not too different, but inside the compiler, they are two different types.
so, if it already a tyGenericInst of ref object, it would be wrong to add more tyRef in front of it.
additional tyRef in the next compiler phase will generate ill formed AST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.