Use higher time resolution when available in os.nim #7709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
approved these changes
Apr 27, 2018
lib/pure/os.nim
Outdated
|
|
||
| # Some systems have Stat.st_*time (second resolution) instead of | ||
| # Stat.st_*tim (nanosecond resolution). | ||
| const StatHasNano = compiles(Stat.st_atim) |
There was a problem hiding this comment.
hrm, I think you can just use declared here. If you can't, you should use the relevant define instead of compiles.
GULPF
force-pushed
the
nanoseconds-in-os
branch
from
1a88b5a
to
67aabc3
Compare
|
Please rebase so that we get accurate test results (sorry!). |
Araq
reviewed
May 4, 2018
lib/pure/os.nim
Outdated
|
|
||
| # Some systems have Stat.st_*time (second resolution) instead of | ||
| # Stat.st_*tim (nanosecond resolution). | ||
| const StatHasNano = not defined(macosx) and not defined(android) |
There was a problem hiding this comment.
Better white-list the OSes that have this feature.
|
Better white-list the OSes that have this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for nanosecond resolution on posix for some procs in os.nim:
futimens can be used to suport nanosecond resolution in
setLastModificationTime, but I don't know if it's available on all of posix