fix nil literal giving itself type untyped/typed [backport]
#24165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes nim-lang#24164, regression from nim-lang#20091
metagn
changed the title
nil literal giving itself type untyped/typednil literal giving itself type untyped/typed [backport:2.0]
metagn
changed the title
nil literal giving itself type untyped/typed [backport:2.0]nil literal giving itself type untyped/typed [backport]
|
@narimiran This can be backported as well for status-im/nim-eth#730 and status-im/nim-confutils#105 |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Sep 23, 2024
…4165) fixes #24164, regression from #20091 The expression `nil` as the default value of template parameter `x: untyped` is typechecked with expected type `untyped` since #20091. The expected type is checked if it matches the `nil` literal with a match better than a subtype match, and the type is set to it if it does. However `untyped` matches with a generic match which is better, so the `nil` literal has type `untyped`. This breaks type matching for the literal. So if the expected type is `untyped` or `typed`, it is now ignored and the `nil` literal just has the `nil` type. (cherry picked from commit b9de2bb)
These are still failing on |
I've now merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24164, regression from #20091
The expression
nilas the default value of template parameterx: untypedis typechecked with expected typeuntypedsince #20091. The expected type is checked if it matches thenilliteral with a match better than a subtype match, and the type is set to it if it does. Howeveruntypedmatches with a generic match which is better, so thenilliteral has typeuntyped. This breaks type matching for the literal. So if the expected type isuntypedortyped, it is now ignored and thenilliteral just has theniltype.