Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI, sem whole when stmts as generic stmt #24072

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Sep 6, 2024

fixes CI, refs #24066, refs #24065

The combination of #24065 and #24066 caused a CI failure where a when branch that was never compiled gave an undeclared identifier error. This is because the when branch was being semchecked with semGenericStmt without withinMixin, which is the flag semgnrc normally gives to when branch bodies. To fix this, just pass the whole when stmt to semGenericStmt rather than the individual blocks.

The alternative would be to just replace the calls to semGenericStmt with a new proc that does the same thing, just with the flags {withinMixin}.

@metagn metagn changed the title sem whole when stmts as generic stmt fix CI, sem whole when stmts as generic stmt Sep 6, 2024
@Araq Araq merged commit 79a65da into nim-lang:devel Sep 8, 2024
19 checks passed
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 79a65da

Hint: mm: orc; opt: speed; options: -d:release
174174 lines; 8.338s; 655.215MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants