fix CI, sem whole when
stmts as generic stmt
#24072
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes CI, refs #24066, refs #24065
The combination of #24065 and #24066 caused a CI failure where a
when
branch that was never compiled gave an undeclared identifier error. This is because thewhen
branch was being semchecked withsemGenericStmt
withoutwithinMixin
, which is the flagsemgnrc
normally gives towhen
branch bodies. To fix this, just pass the wholewhen
stmt tosemGenericStmt
rather than the individual blocks.The alternative would be to just replace the calls to
semGenericStmt
with a new proc that does the same thing, just with the flags{withinMixin}
.