Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nested call regression in generic bodies #22189

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Jun 29, 2023

fixes #22187

What was done for tyGenericParam arguments in calls in generic bodies in #22029 is now done for tyFromExpr parameters. The "fauxMatch" mechanism seems to have been in place for something like this but it made things more confusing than it had to be in this case, at least I can't see the need for it in the current state, so just skip it for tyUnknown (= tyFromExpr apparently) and use the failing overload fallback.

@Araq Araq merged commit 210b10d into nim-lang:devel Jun 29, 2023
@tersec
Copy link
Contributor

tersec commented Jun 29, 2023

Would be interested in a backport to version-2-0 as well.

@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 210b10d

Hint: mm: orc; opt: speed; options: -d:release
168123 lines; 9.216s; 612.344MiB peakmem

@metagn
Copy link
Collaborator Author

metagn commented Jun 30, 2023

The issue is a regression in devel caused by #22029, it's possible there are more regressions so it could stay in devel for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nim c -c SIGSEGV regression between 1.6 and 2.0, both refc and ORC
3 participants