New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #21027; cast expressions need a type #21029

Merged

Araq merged 2 commits into devel from pr_21027

Dec 6, 2022

Member

ringabout commented Dec 6, 2022 •

edited

Loading

fixes #21027


          fixes #21027; cast expressions need a type

afadac3

Araq added the merge_when_passes_CI label

Collaborator

beef331 commented Dec 6, 2022

The present message is not very helpful, I'd suggest something along the lines of "Invalid usage of cast, cast requires a type to convert to. eg: cast[int](0d)".

ringabout commented

View reviewed changes

compiler/semexprs.nim Outdated Show resolved Hide resolved

tests/types/t21027.nim Outdated Show resolved Hide resolved


          Apply suggestions from code review

44ff16b

Thanks to @beef331

Araq merged commit 1564ae6 into devel

Araq deleted the pr_21027 branch

December 6, 2022 12:09

Contributor

github-actions bot commented Dec 6, 2022

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 1564ae6

Hint: mm: orc; opt: speed; options: -d:release
165507 lines; 10.334s; 612.699MiB peakmem

survivorm pushed a commit to survivorm/Nim that referenced this pull request


          fixes nim-lang#21027; cast expressions need a type (nim-lang#21029)

7e019a0

* fixes nim-lang#21027; cast expressions need a type

* Apply suggestions from code review

Thanks to @beef331

capocasa pushed a commit to capocasa/Nim that referenced this pull request


          fixes nim-lang#21027; cast expressions need a type (nim-lang#21029)

433286a

* fixes nim-lang#21027; cast expressions need a type

* Apply suggestions from code review

Thanks to @beef331

narimiran pushed a commit that referenced this pull request


          fixes #21027; cast expressions need a type (#21029)

316b8fe

* fixes #21027; cast expressions need a type

* Apply suggestions from code review

Thanks to @beef331

(cherry picked from commit 1564ae6)

narimiran pushed a commit that referenced this pull request


          fixes #21027; cast expressions need a type (#21029)

29c146d

* fixes #21027; cast expressions need a type

* Apply suggestions from code review

Thanks to @beef331

(cherry picked from commit 1564ae6)

narimiran pushed a commit that referenced this pull request


          fixes #21027; cast expressions need a type (#21029)

6210ddd

* fixes #21027; cast expressions need a type

* Apply suggestions from code review

Thanks to @beef331

(cherry picked from commit 1564ae6)

narimiran pushed a commit that referenced this pull request


          fixes #21027; cast expressions need a type (#21029)

b1996ae

* fixes #21027; cast expressions need a type

* Apply suggestions from code review

Thanks to @beef331

(cherry picked from commit 1564ae6)

narimiran pushed a commit that referenced this pull request


          fixes #21027; cast expressions need a type (#21029)

71c5bdf

* fixes #21027; cast expressions need a type

* Apply suggestions from code review

Thanks to @beef331

(cherry picked from commit 1564ae6)

bung87 pushed a commit to bung87/Nim that referenced this pull request


          fixes nim-lang#21027; cast expressions need a type (nim-lang#21029)

47794a8

* fixes nim-lang#21027; cast expressions need a type

* Apply suggestions from code review

Thanks to @beef331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge_when_passes_CI