Named arguments in commands + many grammar fixes #20994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types are separated from expressions and better reflected in the grammar.
Araq
reviewed
Dec 6, 2022
Araq
added
merge_when_passes_CI
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
survivorm
pushed a commit
to survivorm/Nim
that referenced
this pull request
Feb 28, 2023
* Breaking parser changes, implement nim-lang/RFCs#442 Types are separated from expressions and better reflected in the grammar. * add test * more accurate grammar * fix keyword typedescs * accept expressions in proc argument lists * CI "fixes" * fixes * allow full ref expressions again, adapt old tests * cleanup, fix some tests * improve grammar, try and revert semtypes change * restrict sigil binding to identOrLiteral * fix, should have caught this immediately * add changelog entry, fix double not nil bug * correct grammar * change section * fix * real fix hopefully * fix test * support LL(1) for tuples * make grammar.txt too
ringabout
reviewed
Mar 16, 2023
| @@ -1199,8 +1200,12 @@ proc parseTypeDescKAux(p: var Parser, kind: TNodeKind, | |||
| getTok(p) | |||
| if p.tok.indent != -1 and p.tok.indent <= p.currInd: return | |||
| optInd(p, result) | |||
| let isTypedef = mode == pmTypeDef and p.tok.tokType in {tkObject, tkTuple} | |||
There was a problem hiding this comment.
It seems that
type
Named = tuple or int
doesn't work anymore. Is it expected?
There was a problem hiding this comment.
Yes, tuple in type sections can have a syntax similar to objects, so it becomes tuple[] which is misleading
Hence this bigger example doesn't compile in 1.6:
type Named = tuple or int
proc foo(x: Named) = echo x
foo((1, 2))There was a problem hiding this comment.
I see, thanks for your explanation.
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
* Breaking parser changes, implement nim-lang/RFCs#442 Types are separated from expressions and better reflected in the grammar. * add test * more accurate grammar * fix keyword typedescs * accept expressions in proc argument lists * CI "fixes" * fixes * allow full ref expressions again, adapt old tests * cleanup, fix some tests * improve grammar, try and revert semtypes change * restrict sigil binding to identOrLiteral * fix, should have caught this immediately * add changelog entry, fix double not nil bug * correct grammar * change section * fix * real fix hopefully * fix test * support LL(1) for tuples * make grammar.txt too
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
* Breaking parser changes, implement nim-lang/RFCs#442 Types are separated from expressions and better reflected in the grammar. * add test * more accurate grammar * fix keyword typedescs * accept expressions in proc argument lists * CI "fixes" * fixes * allow full ref expressions again, adapt old tests * cleanup, fix some tests * improve grammar, try and revert semtypes change * restrict sigil binding to identOrLiteral * fix, should have caught this immediately * add changelog entry, fix double not nil bug * correct grammar * change section * fix * real fix hopefully * fix test * support LL(1) for tuples * make grammar.txt too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes nim-lang/RFCs#442, closes #15050, closes #8846 and maybe some other issues, cleans up after #19181
This is a fully rebased version of #19383 I am opening again to bump it up because apparently the time is ticking on 2.0 and it doesn't make sense for it to not have this.
foo a = bnow meansfoo(a = b)instead offoo(a) = b, for consistency withfoo a, b = c. To do this, theprimaryexpression in the grammar, which had many issues and did not reflect reality, had to be slightly overhauled.primaryanymore. Instead they have been broken up intotypeDefValue(right hand sides of type sections) andtypeDesc(everywhere else a type is expected).typeDescitself is broken up into 2:rawTypeDesc(expressions that start with type keywords) andtypeDescExpr(general expressions that may evaluate to types, as well as binarynot). We userawTypeDescas the ordered choice inprimary.identOrLiterals for simplicity. (This seems to break nothing as it doesn't really make sense to apply to anything else)primarySuffixanymore. This never made sense and had many issues. For example, in realityprimaryonly parses 1 command argument, but the grammar denotes an arbitrary number of arguments.=) is now inexprStmt(which it already was, but not in the grammar). We indicate with a parser mode that we want to get away with parsing only asimplePrimary(which is also reflected in the grammar), and if we do we parseexprEqExpr ^+ commafor command syntax. Otherwise we just use the expression that we got.for a, (b, c) in dsyntax with'for' ((varTuple / identWithPragma) ^+ comma)instead of'for' (identWithPragma ^+ comma).