Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes semExpr wrongly erases the seq type of nkbracket #20662

Closed
wants to merge 1 commit into from
Closed

fixes semExpr wrongly erases the seq type of nkbracket #20662

wants to merge 1 commit into from

Conversation

ringabout
Copy link
Member

After the call of semArrayConstr, the type of nkBracket becomes nkArray even though its original type is tySequence.

@ringabout ringabout mentioned this pull request Oct 26, 2022
Merged
@ringabout
Copy link
Member Author

ringabout commented Oct 26, 2022 •
edited
Loading

I made a PR to loop-fusion mratsim/loop-fusion#9 which causes CI failures.

@ringabout ringabout changed the title fixes semExpr wrongly erases the type of nkbracket fixes semExpr wrongly erases the seq type of nkbracket Oct 26, 2022
@Varriount Varriount requested a review from Araq October 27, 2022 17:01
@Varriount Varriount added the Requires Araq To Merge PR should only be merged by Araq label Oct 27, 2022
@bung87

This comment was marked as off-topic.

Sign in to view
@ringabout
Copy link
Member Author

It blocks #20639

@bung87

This comment was marked as off-topic.

Sign in to view
@ringabout

This comment was marked as off-topic.

Sign in to view
@bung87
Copy link
Collaborator

bung87 commented Oct 28, 2022

It doesn't seem to be related to my PR.

I see, it still can rely on old behavior.

@ringabout ringabout mentioned this pull request Oct 28, 2022
Merged
@bung87
Copy link
Collaborator

bung87 commented Dec 21, 2022

conflicts now

@ringabout ringabout removed the Requires Araq To Merge PR should only be merged by Araq label Dec 21, 2022
@ringabout
Copy link
Member Author

I have a PR, which is better than this.

See also #21326

@ringabout ringabout closed this Feb 22, 2023
@ringabout ringabout deleted the pr_type_expr branch February 22, 2023 13:35
@ringabout ringabout mentioned this pull request Sep 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Awaiting requested review from Araq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ringabout @bung87 @Varriount