Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close #15955; add a test case #20414

Merged
merged 1 commit into from
Sep 23, 2022
Merged

close #15955; add a test case #20414

merged 1 commit into from
Sep 23, 2022

Conversation

ringabout
Copy link
Member

close #15955

@Araq Araq added the merge_when_passes_CI mergeable once green label Sep 23, 2022
@ringabout
Copy link
Member Author

ringabout commented Sep 23, 2022 •
edited
Loading

It should be fixed by #19934 (works on windows) let's wait and see

It doesn't work with 1.6.6

@ringabout ringabout merged commit 37ca97d into devel Sep 23, 2022
@ringabout ringabout deleted the pr_staticlib branch September 23, 2022 17:37
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 37ca97d

Hint: mm: orc; threads: on; opt: speed; options: -d:release
164082 lines; 12.111s; 840.531MiB peakmem

capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
close nim-lang#15955; add a test case (nim-lang#20414)
ccad825
narimiran pushed a commit that referenced this pull request Apr 24, 2023
@ringabout @narimiran
close #15955; add a test case (#20414)
07824b3 
(cherry picked from commit 37ca97d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static linking with a .lib file not working
2 participants
@ringabout @Araq