Docs auto dark mode #20188
Merged
Docs auto dark mode #20188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AmjadHD
commented
Aug 9, 2022
AmjadHD
commented
AmjadHD
commented
Aug 9, 2022
AmjadHD
force-pushed
the
auto-dark-mode
branch
from
ca6e7e1 to
1b40aa7
Compare
|
FWIW I needed to add some padding around the sidebar to fix these: |
metagn
reviewed
Aug 14, 2022
|
@ringabout can you review this please ? |
ringabout
reviewed
Aug 18, 2022
|
So, It's Ok to merge now ? |
|
@ringabout I have some modicum of HTML/CSS knowledge, enough to review PRs like this. |
Varriount
requested changes
Aug 19, 2022
Varriount
approved these changes
Aug 21, 2022
|
Thanks for your hard work on this PR! Hint: mm: orc; threads: on; opt: speed; options: -d:release |
a-mr
added a commit
to a-mr/Nim
that referenced
this pull request
Aug 23, 2022
Varriount
added a commit
that referenced
this pull request
Aug 23, 2022
* Add `doctype: RST|Markdown|RstMarkdown` pragma Implements nim-lang/RFCs#68 , see also discussion in #17987 The permitted values: * `markdown`, which is default. It still contains nearly all of the RST supported but it is assumed that in time we will give up most or all RST features in this mode * `rst`, without any extensions * `RstMarkdown` — compatibility with Nim 1.x. It's basically RST with those Markdown features enabled that don't conflict with RST. * Apply suggestions from code review Co-authored-by: Clay Sweetser <[email protected]> * Additional fix in spirit of review * Fix test after #20188 Co-authored-by: Clay Sweetser <[email protected]>
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
* Implement auto dark mode * Rename class * Fix borders cutout * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: ringabout <[email protected]>
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
* Add `doctype: RST|Markdown|RstMarkdown` pragma Implements nim-lang/RFCs#68 , see also discussion in nim-lang#17987 The permitted values: * `markdown`, which is default. It still contains nearly all of the RST supported but it is assumed that in time we will give up most or all RST features in this mode * `rst`, without any extensions * `RstMarkdown` — compatibility with Nim 1.x. It's basically RST with those Markdown features enabled that don't conflict with RST. * Apply suggestions from code review Co-authored-by: Clay Sweetser <[email protected]> * Additional fix in spirit of review * Fix test after nim-lang#20188 Co-authored-by: Clay Sweetser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.