Always use httpclient in nimgrab #19767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is actively using this?, is it the Windows installation process ?. 🤔 |
Yes, it's used for downloading mingw. The discussion was in #internals on Discord |
|
Who can test the resulting |
Tested on Win 11:
I changed the code to show the new nimgarb is actually used:
|
ringabout
approved these changes
May 16, 2022
|
@narimiran can this PR be backported to 1.6.x? This PR seems to be harmless and helps newcomers on windows. 1.6.6
devel
|
Sorry, I have missed this. Should I backport it now? |
|
Yes, please, thanks! |
narimiran
pushed a commit
that referenced
this pull request
Jan 30, 2023
(cherry picked from commit 06f02bb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, nimgrab used the URLDownloadToFile function which seems to be quite old and, on another note, antiviruses seem to be really suspicious towards any applications using this API.
Also changed imports to use
stdand removed an unneededasyncdispatchimport as nimgrab always uses synchronous HttpClient.