-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix RFCs/411: add std/cputicks #18743
Conversation
PTAL |
Please only open these PRs once actual discussion has occurred on their RFCs - otherwise it creates unnecessary noise for reviewers and risks fracturing discussion. A link to the implementation can be given in the RFC. I would also recommend using "implements" or "resolves" rather than "fixes" for PRs like this. "fixes" implies that a PR solves an objective problem, such as a logic bug, rather than a subjective problem. |
I disagree. An RFC becomes much more concrete with a link to a PR that implements it, which users can try and break. This is how you refine ideas and identify problems, otherwise it just remains a vague idea. You can comment on the RFC for the general design/idea, and on the PR for the particulars of the implementation. A link
which is what this PR is, allowing inline comments etc
potato, potato. |
"draft PR":s exists for this reason |
or they can sit in a fork repo, and have equally good integration with github while still reducing noise |
c709535
to
228717c
Compare
30f5fc2
to
94a3211
Compare
This should start its life as a Nimble package. Also: Supporting this at compile-time from the get go is not nice, not everybody enjoys the possibility of a build depending on CPU ticks. |
fix nim-lang/RFCs#411
(split off from #18149 to just focus on adding std/cputicks)