Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove conditionals on nimHasUserErrors, nimNoNilSeqs2, nimNoNilSeqs #16861

Merged
merged 4 commits into from
Jan 29, 2021
Merged

remove conditionals on nimHasUserErrors, nimNoNilSeqs2, nimNoNilSeqs #16861

merged 4 commits into from
Jan 29, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jan 29, 2021 •
edited
Loading

note

any condsyms define flag that passes this test is fine to remove:
nim c -r main for nim bootstrap (currently 0.20.0)

doAssert defined(nimNoNilSeqs2)
doAssert defined(nimHasUserErrors)
doAssert defined(nimNoNilSeqs)

future work

@Araq Araq added the merge_when_passes_CI mergeable once green label Jan 29, 2021
@Araq Araq merged commit 6e267d2 into nim-lang:devel Jan 29, 2021
@timotheecour timotheecour deleted the pr_typeof_nil_equals branch January 29, 2021 18:10
@timotheecour timotheecour mentioned this pull request Mar 1, 2021
Merged
1 task
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@timotheecour @ardek66
remove conditionals on nimHasUserErrors, nimNoNilSeqs2, nimNoNilSeqs (n…
1f96770 
…im-lang#16861)

* cleanup docs for type(nil) | type(nil); simplify nimHasUserErrors

* simplify nimNoNilSeqs2

* simplify nimNoNilSeqs

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timotheecour @Araq