-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up the docs of some modules under lib/js #16579
Conversation
ringabout
commented
Jan 4, 2021
•
edited
Loading
edited
- clean up the docs
- fixees misc cleanups timotheecour/Nim#64 (comment)
|
||
when not defined(js) and not defined(nimdoc) and not defined(nimsuggest): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; in future work
when not defined(js):
{.error: "This module only works on the JavaScript platform".}
would need to use fatal instead, see rationale here: timotheecour#64 (comment)
EDIT: some tests fail that are related to this PR ...
proposed fix: simply remove (another fix would've been this:
but the 1st proposed fix is better/simpler) |
I see, thanks, you are always very helpful!(I was testing it too) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again (if passes CI)