Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sequtils to prelude #16431

Merged
merged 3 commits into from
Dec 23, 2020
Merged

add sequtils to prelude #16431

merged 3 commits into from
Dec 23, 2020

Conversation

shadowninja55
Copy link
Contributor

i would argue that sequtils is used just as often as the other imports in prelude, and it'd be nice for it to be included.

i would argue that sequtils is used just as often as the other imports in prelude, and it'd be nice for it to be included.
@juancarlospaco
Copy link
Collaborator

Yes, please, some people asked for this, sequtils on prelude is very useful. 👍

lib/prelude.nim Outdated Show resolved Hide resolved
Copy link
Member

@ringabout ringabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@timotheecour
Copy link
Member

LGTM, no objection to this PR.

Although I still think import std/stdimports instead of include prelude is a better approach as discussed in #16238

Note: this PR shouldn't be affected by the sequtils.toSeq issue of nim-lang/RFCs#512 (see nim-lang/RFCs#512 for details)

@ringabout ringabout merged commit 6e2c2d1 into nim-lang:devel Dec 23, 2020
@shadowninja55 shadowninja55 deleted the patch-2 branch December 23, 2020 18:38
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
* add sequtils to prelude

i would argue that sequtils is used just as often as the other imports in prelude, and it'd be nice for it to be included.

* updated doc comment to add sequtils

* added sequtils import to changelog
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
* add sequtils to prelude

i would argue that sequtils is used just as often as the other imports in prelude, and it'd be nice for it to be included.

* updated doc comment to add sequtils

* added sequtils import to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants