add strbasics.strip

[ringabout]

Ref RFC timotheecour#422

• more generally, a lot of procs should become inline, the question is whether it'd be in some new strutils2 or in existing strutils (EDIT: some new module was the conclusion)

future work

• investigate why matrix: "c js" passed CI (this shouldn't work, targets should be used); refs add strbasics.strip #16280 (comment)
• moves some/all of compiler/strutils2.nim into std/strbasics and document design goal in strbasics in more details( see also follow up #15951 #17478)
• make strutils.strip call strbasics.strip
• some notes in add strbasics.strip #16280 (comment) and add strbasics.strip #16280 (comment) still relevant

[Araq]

I don't like the name too much and I dislike further strutils bloat. I do really like the code itself though. Not sure where we should put it though.

[timotheecour]

I don't like the name too much and I dislike further strutils bloat. I do really like the code itself though. Not sure where we should put it though.

then it's finally time for std/stringutils (we can bikeshed the name) with following properties:

• low-dependency module (no dependencies on math, etc unlike strutils; possibly no dependency on unicode either)
• efficiency first (only inplace procs, etc), defines building blocks used by other higher level modules; in particular focuses on inplace procs (and relies on sugar.dup + outplace argument _ RFCs#292)
• std/strutils imports it and re-exports some symbols (more and more over time)
• fixes some issues like the fact that strutils.isLowerAscii+friends can't be {.inline.} since it's rtl, as @xflywind noted in chat
• moves some/all of compiler/strutils2.nim into std/stringutils
• no {.rtl.} procs

note

• can't be fusion/stringutils because the intent is to be reused by other stdlib modules
• if needed, for a staging period we can put it in lib/std/private/stringutils.nim and move it to std/stringutils after some time

[konsumlamm]

I still don't see why we need to make a new module for this. Why not put it in strmisc for example (as @juancarlospaco suggested)?

Also, it's not obvious at all what stropt is supposed to mean. "string optimized"? "string optional"? In particular, there are no module level doc comments explaining what this module is about.

[ringabout]

I still don't see why we need to make a new module for this. Why not put it in strmisc for example (as @juancarlospaco suggested)?

• strmisc depends on std/strutils which is a huge dependency for stropt which is intended for low level high performance string operations. And in fact std/strutils should imports this module and reexport some procs or variables.

• stuffs which are in strmisc are for something uncommonly used while stropt should be used throughout Nim repo.

This module contains various string utility routines that are uncommonly used in comparison to strutils <strutils.html>_.

see also #16280 (comment)

then it's finally time for std/stringutils (we can bikeshed the name) with following properties:
low-dependency module (no dependencies on math, etc unlike strutils; possibly no dependency on unicode either)
efficiency first (only inplace procs, etc), defines building blocks used by other higher level modules; in particular focuses on inplace procs (and relies on sugar.dup + nim-lang/RFCs#292)
std/strutils imports it and re-exports some symbols (more and more over time)
fixes some issues like the fact that strutils.isLowerAscii+friends can't be {.inline.} since it's rtl, as @xflywind noted in chat
moves some/all of compiler/strutils2.nim into std/stringutils
no {.rtl.} procs

In the future PR, lots of things should be moved into std/stropt especially the functions in std/strutils can't be marked as inline which causes a lot of performance loss.

more generally, a lot of procs should become inline, the question is whether it'd be in some new strutils2 or in existing strutils

Also, it's not obvious at all what stropt is supposed to mean. "string optimized"? "string optional"? In particular, there are no module level doc comments explaining what this module is about.

It is called string optimized. We already have one line comment.

This module provides some high performance string operations.

[Araq]

Name it strbasics please.

[juancarlospaco]

What about...

Splitting a tiny in-place efficient charutils out of strutils,
charutils does not depend on strutils,
strutils imports charutils,
charutils has all proc that work on char, var char and collection of char,
strutils has all proc that work on string and var string, and collection of string,
makes strutils more lightweight because is kinda big,
charutils can be improved without touching strutils nor creating yet another strutils.

[Araq]

Splitting a tiny in-place efficient charutils out of strutils,

That's the plan, yes, but the focus on char isn't right, it's still about strings.

[timotheecour]

s/teststrip/main (since it's testing other procs

[timotheecour]

• Added std/strbasics containing strip and setSlice.

[timotheecour]

see whether we can use copyWithin see developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/copyWithin

(refs #16280 (comment))