move rest of tests to testament #16140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why this fails? I can't understand. It shouldn't be OS specfic 2020-11-26T03:58:00.5999865Z tsums.nim(9) tsums
2020-11-26T03:58:00.6000107Z assertions.nim(30) failedAssertImpl
2020-11-26T03:58:00.6000373Z assertions.nim(23) raiseAssert
2020-11-26T03:58:00.6000611Z fatal.nim(49) sysFatal
2020-11-26T03:58:00.6001113Z Error: unhandled exception: tsums.nim(9, 8) `sumPairs(data) != 1.0` [AssertionDefect]
2020-11-26T03:58:00.6001526Z
2020-11-26T03:58:00.6001709Z FAIL: megatest execution failed |
|
32 bit float => loss of precision |
|
@timotheecour |
ringabout
commented
Nov 27, 2020
tests/stdlib/tsums.nim
Outdated
| epsilon /= 2.0 | ||
| let data = @[1.0, epsilon, -epsilon] | ||
| assert sumKbn(data) == 1.0 | ||
| assert sumPairs(data) != 1.0 # known to fail |
There was a problem hiding this comment.
Suggested change
| assert sumPairs(data) != 1.0 # known to fail | |
| # assert sumPairs(data) != 1.0 # known to fail in 64 bits |
There was a problem hiding this comment.
It is disabled now.
Or?
When sizeof(int) == 8:
assert sumPairs(data) != 1.0 # known to fail
There was a problem hiding this comment.
Use when (likewise, when defined posix is used a lot in runnableExamples)
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* move rest of tests to testament * Update tests/stdlib/tsums.nim
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* move rest of tests to testament * Update tests/stdlib/tsums.nim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.