-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disallow typedesc in arrays & move existing checks to types.typeAllowedAux
#13261
Conversation
But this is arbitrary, instead it should call |
types.typeAllowedAux
result = t | ||
else: | ||
# XXX: This is still a horrible idea... | ||
result = nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can it still happen now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was existing code, so i don't know anything about this.
While reviewing, use the settings icon to Hide Whitespace Changes in order to see which code this PR changes.
All tests pass. Ready for review. @Araq Edit: Why does |
you can upvote the issue I filed: microsoft/azure-pipelines-agent#2944 |
Do not use |
AFAICT, the currently used CI services azure, github actions as well as builds.sr.ht do not support [ci skip], so we cannot use it anyways. |
it's still useful for in-progress work, but yes when it's getting finalized CI is almost always needed. |
Superb work, many thanks! |
Closes #9932