-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature dracula themed doc #12816
feature dracula themed doc #12816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any screenshots?
config/nimdoc.cfg
Outdated
@@ -450,7 +595,7 @@ h1 { | |||
font-size: 1.8em; | |||
font-weight: 400; | |||
padding-bottom: .25em; | |||
border-bottom: 1px solid #aaa; | |||
border-bottom: 6px solid var(--third-background); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that support for these isn't 100% https://caniuse.com/#feat=css-variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the listed browser (versions) are either mobile or are really really outdated. I doubt that you'd go ahead and actually use Nim's documentation on mobile. And even if you would do that, most browsers for mobile now support that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PC:
- Edge (Since Oct 17, 2017)
- Firefox (Since Jul 22, 2014)
- Chrome (Since Mar 3, 2016)
- Safari (Since Mar 21, 2016)
- Opera (Since Mar 7, 2016)
Mobile:
- Safari & Chrome for iOS (Since Mar 21, 2016)
- Android Browser (Since Aug 26, 2019 - Android Browser has huge gaps between releases, see the page you linked, click on "Date Relative")
- Opera Mobile (Since Sep 23, 2016)
- Chrome for Android (Since Oct 22, 2019)
- Firefox for Android (Since Sep 3, 2019)
- UC Browser for Android (Since Aug 17, 2016)
- Samsumg Internet (Since Dec 16, 2016)
- KaiOS Browser (Since Jun 1, 2018)
Unsure:
- QQ Browser:
- Latest release Jan 1, 2017 according to caniuse.com
- No releases ever since according to caniuse.com
- Wikipedia states: On October 18, 2017, QQ browser 9.6 was released and the engine was upgraded to Chromium(/Chrome) V53
- Baidu Browser:
- Latest release Apr 1, 2017 according to caniuse.com
- No releases ever since according to caniuse.com
- Google Play states: Latest update was November 21, 2019
Not supported:
- Opera Mini (Compensated by Opera Mobile)
<input type="checkbox" id="checkbox" /> | ||
<div class="slider round"></div> | ||
</label> | ||
<em>Dark Mode</em> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use CSS here instead of the  
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well yeah, it's doable but I thought
to be an easier minor-ish solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be an easier minor-ish solution that does the job for now. There are actually plans or ideas to move the whole css to dedicated stylesheets.
Screenshots can be looked up here: #12797 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Love the new look :)
No description provided.