Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase verbosity of logGC #10449

Merged
merged 2 commits into from
Jan 26, 2019
Merged

Increase verbosity of logGC #10449

merged 2 commits into from
Jan 26, 2019

Conversation

iffy
Copy link
Contributor

@iffy iffy commented Jan 24, 2019

I don't know if these changes would be valuable to anyone else, but they have been of some benefit to me. AFAICT this is a non-breaking change.

Copy link
Member

@timotheecour timotheecour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i really wish we could introduce namespace scope to avoid conflicts eg defined(nim.logGC)

lib/system/gc.nim Outdated Show resolved Hide resolved
lib/system/gc.nim Outdated Show resolved Hide resolved
lib/system/gc.nim Outdated Show resolved Hide resolved
@iffy
Copy link
Contributor Author

iffy commented Jan 25, 2019

@timotheecour

i really wish we could introduce namespace scope to avoid conflicts eg defined(nim.logGC)

Maybe going forward do it by convention? (e.g. nim_logGC)

@Araq Araq merged commit 3c10654 into nim-lang:devel Jan 26, 2019
ThomasTJdev pushed a commit to ThomasTJdev/Nim that referenced this pull request Jan 27, 2019
* Increase verbosity of logGC

* Remove & c.repr to avoid re-entering the GC
@timotheecour
Copy link
Member

i really wish we could introduce namespace scope to avoid conflicts eg defined(nim.logGC)
Maybe going forward do it by convention? (e.g. nim_logGC)

=> followed up here: nim-lang/RFCs#124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants