Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix off by 1 error in col shown by toFileLineCol #10138

Merged
merged 2 commits into from
Dec 31, 2018
Merged

fix off by 1 error in col shown by toFileLineCol #10138

merged 2 commits into from
Dec 31, 2018

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Dec 31, 2018 •
edited
Loading 

coordToStr(context.info.col+1)]

compiler/msgs.nim:

  # NOTE: currently line info line numbers start with 1,
  # but column numbers start with 0, however most editors expect
  # first column to be 1, so we need to +1 here

@timotheecour timotheecour mentioned this pull request Dec 31, 2018
Merged
@Araq Araq merged commit ab72d68 into nim-lang:devel Dec 31, 2018
@timotheecour timotheecour deleted the pr_fix_toFileLineCol branch December 31, 2018 19:38
@timotheecour timotheecour mentioned this pull request Jan 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timotheecour @Araq