warningaserror doesn't respect package boundaries (foreign package notes)

[timotheecour]

Example 1

import os

Current Output

XDG_CONFIG_HOME= nim r --warningaserror:deprecated main
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(143, 30) Error: NimIdent is deprecated [Deprecated]

Expected Output

works because macros is a foreign package wrt main

Example 2

import os
echo existsDir(".")

XDG_CONFIG_HOME= nim r --warningaserror:deprecated main2

the relevant error appears only with --errormax:50

/Users/timothee/git_clone/nim/timn/tests/nim/all/t11723.nim(6, 6) Error: use dirExists; existsDir is deprecated [Deprecated]

and there are some strange errors, eg:

times.nim(2019, 28) Error: can raise an unlisted exception: ref TimeFormatParseError

XDG_CONFIG_HOME= nim r --warningaserror:deprecated --errormax:50 --skipparentcfg $timn_D/tests/nim/all/t11723.nim
Hint: used config file '/Users/timothee/git_clone/nim/Nim_devel/config/nim.cfg' [Conf]
Hint: used config file '/Users/timothee/git_clone/nim/Nim_devel/config/config.nims' [Conf]
..........
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(143, 30) Error: NimIdent is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(147, 18) Error: NimIdent is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(155, 18) Error: NimSym is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(234, 26) Error: NimIdent is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(237, 27) Error: NimSym is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(240, 18) Error: NimSym is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(252, 16) Error: NimIdent is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(256, 16) Error: NimSym is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(387, 34) Error: NimSym is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(390, 33) Error: NimIdent is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(450, 23) Error: NimIdent is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(453, 16) Error: Deprecated since version 0.18.1; Generate a new 'NimNode' with 'ident(string)' instead.; ident= is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(687, 24) Error: NimIdent is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/core/macros.nim(692, 14) Error: newIdentNode is deprecated [Deprecated]
........
/Users/timothee/git_clone/nim/Nim_devel/lib/posix/posix.nim(879, 23) Error: use `csize_t` instead; csize is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/posix/posix.nim(879, 31) Error: use `csize_t` instead; csize is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/posix/posix.nim(885, 21) Error: use `csize_t` instead; csize is deprecated [Deprecated]
/Users/timothee/git_clone/nim/Nim_devel/lib/posix/posix.nim(885, 29) Error: use `csize_t` instead; csize is deprecated [Deprecated]
...
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/times.nim(2024, 20) template/generic instantiation of `format` from here
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/times.nim(2017, 65) template/generic instantiation from here
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/times.nim(2019, 28) Error: can raise an unlisted exception: ref TimeFormatParseError
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/times.nim(2038, 20) template/generic instantiation of `format` from here
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/times.nim(2017, 65) template/generic instantiation from here
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/times.nim(2019, 28) Error: can raise an unlisted exception: ref TimeFormatParseError
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/times.nim(2125, 8) template/generic instantiation of `parse` from here
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/times.nim(2110, 22) template/generic instantiation from here
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/times.nim(2112, 28) Error: can raise an unlisted exception: ref TimeFormatParseError
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/times.nim(2143, 20) template/generic instantiation of `format` from here
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/times.nim(2017, 65) template/generic instantiation from here
/Users/timothee/git_clone/nim/Nim_devel/lib/pure/times.nim(2019, 28) Error: can raise an unlisted exception: ref TimeFormatParseError
/Users/timothee/git_clone/nim/timn/tests/nim/all/t11723.nim(6, 6) Error: use dirExists; existsDir is deprecated [Deprecated]

Additional Information

• 1.5.1 6c07b0a
• --hintAsError:X (analog to --warningAsError:X) #16763 (hintAsError) has the same issue

[narimiran]

Current Output
XDG_CONFIG_HOME= nim r --warningaserror:deprecated main

What is this? I've seen it in your other issue reports and I have no idea what XDG_CONFIG_HOME= does, how it is related to Nim, and how to (automatically) reproduce it.
And what Nim command produces XDG_CONFIG_HOME= as output (as this is reported under "Current Output")?

[timotheecour]

What is this? I've seen it in your other issue reports and I have no idea what XDG_CONFIG_HOME= does

FOO= cmd sets environment variable FOO to empty for the call to cmd (and applies to child processes), so i this case XDG_CONFIG_HOME= nim r --warningaserror:deprecated main has effect of ignoring user config (eg ~/.config/nim/) in the call to nim r --warningaserror:deprecated main as well as child processes in cases main calls into nim itself. --skipusercfg would by contrast not apply to child processes, and would also not be available for other invocations, for eg nim r testament/testament all. In short, XDG_CONFIG_HOME= cmd prevents your custom environment from interference.