-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Referring to a static nil objects's field is impossible, even when it should #12559
Comments
It's worse than that: Exampleimport sequtils
type T = ref object
x: int
proc foo(arg: static T) =
static:
assert arg == nil or arg.x > 0
foo nil Current Output/usercode/in.nim(10, 5) template/generic instantiation of |
Isn't Also, if instead of a proc, you define a macrom then it is catched correctly:
Then you get:
Afaik both results (undefined for proc and nil address for macro) are correct, in my humble opninion. |
Well, if it's a wont-fix, is there any other way to do compile-time checking on arguments like this? |
It's not a wont-fix, it looks like a real bug to me. |
should do |
refs (fixes) nim-lang#7611, nim-lang#12559, nim-lang#16969, nim-lang#17423 but not nim-lang#23343
fixes #23010, split from #24195 When resemming bracket nodes, the compiler currently unconditionally makes a new node with an array type based on the node. However the VM can generate bracket nodes with `seq` types, which this erases. To fix this, if a bracket node already has a type, we still resem the bracket node, but don't construct a new type for it, instead using the type of the original node. A version of this was rejected that didn't resem the node at all if it was typed, but I can't find it. The difference with this one is that the individual elements are still resemmed. This should fix the break caused by #24184 so we could redo it after this PR but it might still have issues, not to mention the related pre-existing issues like #22793, #12559 etc.
Example
Current Output
Expected Output
The standard error message for when trying to access a nil ref
Additional Information
The text was updated successfully, but these errors were encountered: