Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ignore_access and ignore_restrictions API flags #217

Conversation

eikes
Copy link
Contributor

@eikes eikes commented Apr 11, 2024

πŸ‘¨β€πŸ’» Changes proposed

Expose ignore_access and ignore_restrictions API flags to show how they change the generated routes

@nilsnolde
Copy link
Owner

Thanks @eikes! eslint failed it seems. once that’s fixed we’ll get a preview.

@nilsnolde
Copy link
Owner

there's now other eslint problems. does a npm install && npm run build work for you? it doesn't seem like CI executes eslint explicitly: https://github.com/gis-ops/valhalla-app/blob/2661dc687005a3e75b908d78a81eb19b2dbe8d09/.github/workflows/deploy.yml#L26C11-L26C24. so I guess it's part of npm run build.. (not so fond of and used to JS ;))

@eikes
Copy link
Contributor Author

eikes commented Apr 12, 2024

I totally misread the eslint / prettier output. I thought it wanted me to remove trailing commas, but it was showing a symbol for space, which I have finally found and removed:

Delete `Β·`  prettier/prettier

@eikes
Copy link
Contributor Author

eikes commented Apr 12, 2024

The "Preview Deploy" step still seems to have failed. But I don't think that's related to these changes.

@nilsnolde
Copy link
Owner

sorry for the long wait! yeah right, I forgot that forks don't have access to our secrets, sorry about that.. that makes our workflow really less useful. github should just require an admin to approve running the workflow if it's coming from a fork and ideally even tell me that "attention, secret being used in workflow". I don't know how to set this up better in the meantime. gh pages won't work, no dynamic subdomain possible. it's such a nice idea, but half-fails in reality..

@nilsnolde nilsnolde merged commit 98de6b6 into nilsnolde:master Apr 26, 2024
1 of 2 checks passed
@eikes eikes deleted the expose_flags_to_ignore_access_and_restrictions branch April 29, 2024 23:09
@eikes
Copy link
Contributor Author

eikes commented Apr 30, 2024

Looks good on valhalla.openstreetmap.de now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants