Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added vite #175

Closed
wants to merge 11 commits into from
Closed

added vite #175

wants to merge 11 commits into from

Conversation

sammaji
Copy link

@sammaji sammaji commented Apr 4, 2023

πŸ› οΈ Fixes Issue #171

πŸ‘¨β€πŸ’» Changes proposed

  • added vite as dev dependency
  • added scripts to run vite servers
  • created main.jsx which is the entrypoint (if vite is used). For now main.jsx has a dummy text.
  • added path aliases for vite

πŸ“„ Note to reviewers

πŸ“· Screenshots

@sammaji
Copy link
Author

sammaji commented Apr 4, 2023

added path aliases for vite

@sammaji
Copy link
Author

sammaji commented Apr 4, 2023

Fixed parsing error
Added @babel/eslint-parser in the .eslintrc.json file

parser

parser2

@sammaji
Copy link
Author

sammaji commented Apr 4, 2023

  1. Vite uses import.meta.env instead of process.env to access environment variables
  2. Only the environment variables starting with VITE_ are exposed.

@sammaji sammaji changed the title added vite [Do not mege] added vite Apr 7, 2023
@nilsnolde nilsnolde marked this pull request as draft April 10, 2023 10:41
Comment on lines +12 to +14
find: 'actions',
replacement: path.resolve(__dirname, './src/actions'),
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it needs to be told how to resolve import paths? or what is that for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It matches for the word in the import statement and replaces it with the given path.

so, vite interprets: import "action/file.jsx" as import "./src/actions/file.jsx"

Its optional.

@nilsnolde nilsnolde changed the title [Do not mege] added vite added vite Apr 10, 2023
@sammaji sammaji closed this by deleting the head repository May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants