Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTHER] Clean up repo #143

Open
tommach591 opened this issue Mar 22, 2023 · 1 comment
Open

[OTHER] Clean up repo #143

tommach591 opened this issue Mar 22, 2023 · 1 comment

Comments

@tommach591
Copy link
Contributor

tommach591 commented Mar 22, 2023

What would you like to share?

I noticed that the files are a bit unorganized/inconsistent in my opinion and I would like to clean it up during the GSoC 2023 alongside #68. (Not the red, not sure why those are there, could be VSCode.)

Capture

I am suggesting to revise the files like so:

ComponentName - folder name

  • ComponentName.jsx - the functional component
  • ComponentName.css - a css file to overwrite the parent css
  • index.js - import ComponentName from ./ComponentName.jsx and export default ComponentName so files can just import as ./ComponentName instead of ./ComponentName/ComponentName
  • other necessary js files/components - children components or js files used solely in ComponentName

This would make the repo easier to work with.

@nilsnolde
Copy link
Owner

Yeah absolutely! It's not very clean IMO either. We'll get to that during the project, thanks for raising!

shreyarora12 added a commit to shreyarora12/valhalla-app that referenced this issue Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants