revert #64 #71
Merged
revert #64 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsnolde
commented
Jul 11, 2022
| @@ -27,7 +27,7 @@ | |||
| class OSRM: | |||
| """Performs requests to the OSRM API services.""" | |||
|
|
|||
| _DEFAULT_BASE_URL = "https://router.project-osrm.org" | |||
| _DEFAULT_BASE_URL = "https://routing.openstreetmap.de/routed-bike" | |||
There was a problem hiding this comment.
finally updated the default url
nilsnolde
commented
Jul 11, 2022
| ) | ||
|
|
||
| def directions( | ||
| self, | ||
| locations, | ||
| profile, | ||
| profile="driving", |
There was a problem hiding this comment.
assuming most people want to hit the public servers
nilsnolde
commented
Jul 11, 2022
| @@ -349,21 +360,23 @@ def matrix( | |||
| ) | |||
|
|
|||
| params = self.get_matrix_params( | |||
| locations, profile, sources, destinations, annotations, **matrix_kwargs | |||
| locations, profile, radiuses, bearings, sources, destinations, annotations, **matrix_kwargs | |||
There was a problem hiding this comment.
weirdly, radiuses and bearings were missing from matrix requests
chrstnbwnkl
suggested changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #70
reverts #64 but mentions more explicitly what one can expect of osrm's "profile" parameter.