Random stuff

[GroobleDierne]

Random stuff and cleanups of my recent work :)

[GroobleDierne]

@nikosgram I think you can add what I put in 8b51eee in the release changelog

[GroobleDierne]

Small question, I feel like this line is dead code, I don't see in which situation the check would succeed.

[nikosgram]

Could we potentially do the migration on the startup of the plugin?

[GroobleDierne]

Could we potentially do the migration on the startup of the plugin?

I tried but ebean crashes as soon as the connection is opened. It could have been possible if the part of EBean that handles the migration was setup previously but it is not the case (I'm not blaming you I don't think it even existed in the version of EBean that was previously used lol)

[GroobleDierne]

I'll leave this as draft for now I still have things to upstream

[GroobleDierne]

@nikosgram is the : separator a convention or is it arbitrary? Because towny uses -
https://github.com/nikosgram/gringotts/blob/master/src/main/java/org/gestern/gringotts/api/impl/GringottsEco.java#L134

[GroobleDierne]

Now that chunk loading is no longer a problem I found other bottlenecks and got rid of them.
That is some juicy performance improvements 😋
Profiling was done when doing /t claim:
Before: https://spark.lucko.me/Mh6i8TPvgo
(3164ms spent in Gringotts)
After: https://spark.lucko.me/cMCGuQPNA5
(16ms spent in Gringotts and I had to lower the lag threshold to be able to capture something)

[Relaxing9]

typo: way data are stored --> data is stored.