fix(service): make whatsapp no-op #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package whatsapp is currently a [ NO-OP ] service! We're sorry for the inconveniences. We're already working on a fix. Please read this [1] for more. Thanks! [1]:#274
nikoksr
added
affects/docs
Codecov ReportBase: 64.34% // Head: 72.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
==========================================
+ Coverage 64.34% 72.18% +7.84%
==========================================
Files 32 30 -2
Lines 1091 924 -167
==========================================
- Hits 702 667 -35
+ Misses 324 197 -127
+ Partials 65 60 -5 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
svaloumas
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make WhatsApp service no-op.
Motivation and Context
As already described in #274 the WhatsApp service is currently in a broken state due to the abandoned client library. Recently the broken service started to block our CI pipeline, hence we're making it a no-op service for the time being. We're already working on the implementation of the new WhatsApp client, hang in there!
How Has This Been Tested?
Ran test suite locally and did a stub implementation.
Types of changes
Checklist: