Fixes #586, #678: Traymenu workspace statuses are not updating #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitabobko
reviewed
Nov 27, 2024
| @@ -19,4 +26,17 @@ func updateTrayText() { | |||
| ($0.activeWorkspace == focus.workspace && sortedMonitors.count > 1 ? "*" : "") + $0.activeWorkspace.name | |||
| } | |||
| .joined(separator: " │ ") | |||
| TrayMenuModel.shared.workspaceStatus = Workspace.all.map { (workspace: Workspace) in | |||
There was a problem hiding this comment.
Thanks, I don't think that it's the right way in Swift UI. You're mixing UI (WorkspaceButton) into ViewModel/ObservableObject (TrayMenuModel)
Anyway, the bug should be fixed in main branch now d172dfd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I moved the workspace
Toggles in the menu inside a@Publishedproperty of theObservableObjectto allow information flow. Then, theToggles are updated along with the tray text insideupdateTrayText().Thanks!!