Going full screen swaps side by side windows

[tomfran]

Hi, I noticed a problem on side by side windows after going full screen with one of them.

Basically, I started with the video on the left, went full screen, pressed esc, and the original placement swapped.

---

Initial state

Full Screen on the video

Press esc

[nikitabobko]

It is by design (kinda)

When you fullscreen the window, the window detaches from the tree. When you exit fullscreen, the window attaches back to the tree

When the window attaches back to the tree, we need to find the position where to attach it. The current algorithm is to attach it after the most recently used window in the tree

In general case, after you detach window from the tree, the tree could be changed in an unpredictable way, so when you want to attach the window back, there is no such thing as "windows previous position", the tree has changed

In version 0.8.x, AeroSpace didn't detached and attached windows but kept fullscreen windows in the tree. Keeping the windows in the tree leads to phantom "holes" in the tree. See #18

[tomfran]

Oh I see, thank you for the quick response!

[mpasa]

This happens for fullscreen video players and it's quite irritating. For example, if I have a browser with a YouTube page split like this.

+------------------------------------+---------------+
|              YouTube               |   Terminal    |
|               (70%)                |     (30%)     |
|                                    |               |
|                                    |               |
|                                    |               |
+------------------------------------+---------------+

Now, if you make the video on YouTube full screen and you close it, instead of going back to the previous layout, you will get:

+--------------------------+--------------------------+
|       Terminal           |          YouTube         |
|         (50%)            |          (50%)           |
|                          |                          |
|                          |                          |
|                          |                          |
+--------------------------+--------------------------+

[bekaman7]

I second this. It's not very nice when you transform your browser to be at a certain position + of a certain size and then lose all that by simply fullscreening a video.