-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add intances of the Storable class. #15
Conversation
Generate the functions `sizeOf` with the sum of the sizes of the elements, `alignment` with the maximum alignment, and peek and poke. Note that the commit also removes some trailing whitespaces.
Thanks for your contribution. Unfortunately, as Travis indicates, your PR fails to compile with GHC 7.8 and 7.10. So I can't merge it until the issue is fixed. |
Is there a way to view a detailed error message? Because I suspect the issue is a timeout when compiling. |
You may be right, since this project requires long compilation times, however 10 minutes seems just too long. Usually it is an indication of an infinite loop during compilation, and since we're dealing with compile-time macros here, chances are, it is the case. |
The log for 7.8 says it compiles correctly, but timesout on the As for the 7.10 build, they made some changes to the TH API, and I am working on it. |
Oh. You're right. It actually failed on both executions on 7.8 the first time, but then I relaunched the build and one of them just passed fine. I've relaunched the other one again just now - we'll see how it'll go. Probably there is no issue with 7.8 compatibility and it merely takes doctest too long to run. |
I've updated the Travis configuration to extend the 10 minute timeout. We'll see whether the commit aa594e5 fixes the issues for 7.8. |
Thank you! More time seemed to solve the issue! I still find weird that the new build, with the extra time, took less time than the previous one, and would therefore not need the extra time.... I will try to solve the issue with 7.10 |
For TH >= 2.10.0 instance contexts are simple types. This change applies to the instance for `Storable`.
It should work now (compiles locally), but for 7.10 Travis complains with the error (Also, I don't know if this pull request is taking into account the commit aa594e5 where you solved the timeout issue. What would be proper here? For me to merge |
It's merged and released now as 0.2.2. Thanks again for your contribution and for being responsible.
I didn't manage to solve it. That bug is the sole reason why failures are allowed for the 7.10 build target. |
Oops. I forgot that I had some unreleased API-changing updates on master. So a proper version for this is 0.3.0. |
Thanks for merging! And for the hard work you put on this library. Shame about the cabal bug. |
This addresses issue #14.
I am not very experienced with TH, but this compiles and seems to do the Right Thing when I tested it on a side project.
Do you have any guidelines to contributing, regarding for example code style?