add getProperties() and getConstants() to ClassLike

[TomasVotruba]

As there is getMethods() at ClassLike, I often tend to use getProperties() and getConstants(), but there are none. I understood that's probably because only getMethods() is in ClassLike for all 3 sub-classes.

Yet the API is inconsistent and confusing. This would fix that.

foreach ($class->stmts as $stmt) {
    if (! $stmt instanceof Property) {
        continue;
    }

    // do something
}   

vs.

foreach ($class->getMethods() as $method) {
    // do something
}   

This keeps happening to me last 2 years so I finally do something about it

[nikic]

I think these should just be on ClassLike. I know not everything is supported everywhere, but that just means you get an empty array (also, at the parser level they are supported anyway...)

[TomasVotruba]

Even if constants are not allowed in traits and properties are not allowed in interfaces?

[TomasVotruba]

CI fail is not related to this feature, but rather some bug in
https://travis-ci.org/nikic/PHP-Parser/jobs/578377375#L346

The command "if [ $TRAVIS_PHP_VERSION = '7.2' ]; then test_old/run-php-src.sh; fi" exited with 1.

[nikic]

@TomasVotruba Fixed with 5644a91.

[nikic]

Even if constants are not allowed in traits and properties are not allowed in interfaces?

I think so. For a couple of reasons:

• I expect that at least properties in interfaces will be supported in the future.
• While this is forbidden by the language, the parser still accepts both constants in traits and properties in interfaces.
• For the user, it is easier to just treat this generically -- you can write code that calls $classLike->getProperties() and just get back an empty array for interfaces, but don't have to do anything to explicitly distinguish those cases.

[TomasVotruba]

Ok, I'd prefer it too, less code to maintain and more ClassLikely :)

Will re-do. Thanks for reasoning 👍

[TomasVotruba]

Thank you 👍