Fixes/3540 undhandled promises for wait commands #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravityvi
commented
Jan 13, 2023
Comment on lines
+132
to
+143
| if (this.shouldRejectNodePromise(err, node)) { | ||
| node.reject(err); | ||
| } else { | ||
| this.currentNode.resolve(err); | ||
| node.resolve(err); | ||
| } | ||
|
|
||
| if (this.shouldRejectParentNodePromise(err)) { | ||
| if (this.shouldRejectParentNodePromise(err, node)) { | ||
| parent.reject(err); | ||
| } | ||
| } else { | ||
| node.resolveValue = result; | ||
| this.resolveNode(this.currentNode, result); | ||
| this.resolveNode(node, result); |
There was a problem hiding this comment.
Instead of using this.currentNode which might have changed during execution (When there are events like abortOnFailure currentNode is shifted to rootNode), I've changed it node which is stored in the context while executing this function.
gravityvi
commented
Jan 13, 2023
| @@ -48,7 +48,7 @@ describe('expect(element.<command>) - passed', function() { | |||
| const testsPath = path.join(__dirname, '../../../apidemos/expect-global/expect.js'); | |||
|
|
|||
| Mocks.elementNotSelected(); | |||
| Mocks.elementProperty('0', 'className', {value: ['div-container']}); | |||
| Mocks.elementProperty('0', 'className', {value: ['container']}); | |||
There was a problem hiding this comment.
This change is fixing a test which not reported earlier. The Nightwatch-test running inside this test has two expect out of which one should fail but without this change there would be two failures.
Nightwatch-Test: https://github.com/nightwatchjs/nightwatch/tree/main/test/apidemos/expect-global/expect.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
runChildNodein asynctree.jsImpacts