Wip/portuguese #730
Closed
Wip/portuguese #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added some missing sbx.scaleBg's
Notifications generated by BWP were missing a sbx.scaleBg() around raw values
fix lots of little issues reported by codacy
Fix for the AR2_USE_RAW option and 0 values
remove some duplication when formatting messages
less code in client.js and using it for messages too
converted the direction to a plugin
fix a bug that caused auto ack'd messaages to be sent over and over
Plugin Base test using jsdom
treatment tests
date field too short on european style of date
date locale fix
alias subscription to /downloads/$username/protobuf
basic translation module
ns translation
Update Dev
Current coverage is
|
| @@ -16,17 +16,17 @@ function storage (collection, storage, pushover) { | |||
| obj.created_at = created_at.toISOString(); | |||
|
|
|||
| var preBolusCarbs = ''; | |||
| if (obj.preBolus > 0 && obj.carbs) { | |||
| if (obj.preBolus != 0 && obj.carbs) { | |||
There was a problem hiding this comment.
|
Closing this while we get a PR that targets the dev branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I added a few Portuguese translations. Does that work?