D3 cleanup #5236
Merged
D3 cleanup #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jpcunningh
commented
Nov 23, 2019
jpcunningh
commented
- Trims the open-top rectangle to not extend into the focus area y axis.
- Handles clearing the timeago alarm styles a little better
- Don't set the direction if the SGV is not current
jakobsandberg
suggested changes
Nov 28, 2019
npm-shrinkwrap.json
Outdated
| @@ -2272,7 +2272,7 @@ | |||
| }, | |||
| "browserify-aes": { | |||
| "version": "1.2.0", | |||
| "resolved": "https://registry.npmjs.org/browserify-aes/-/browserify-aes-1.2.0.tgz", | |||
There was a problem hiding this comment.
Were these changes to npm-shrinkwrap.json intentional? Most of them point us to the npm registry via HTTP instead of HTTPS. I think we should remove them from the PR.
There was a problem hiding this comment.
Thanks, @jakobsandberg. I rolled them back as you suggested.
jakobsandberg
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.