-
Notifications
You must be signed in to change notification settings - Fork 71.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Nightscout 0.12.4 #4927
Conversation
This modal dialog about converting the profile to a format that 0.9.0 or earlier won't support is still popping on fresh installs, shouldn't be required at this point.
If I start nightscout from other path, e.g. from `/opt` and nightscout is in `/opt/cgm-remote-monitor`, it tries to find `/opt/tmp` what does not exist.
Fixed plugin settings being displayed in other settings pages
Allow start nightscout from other directories but cgm-remote-monitor
staleTime div is missing in the clockview
Don't show calculated insulin next to carbs
Remove profile conversion warning
Fixed issue with incorrect temporary target validation
Rewording of the "wrong profile" dialog
* Fix clock if authentication is enabled Add .npmignore file * Add time to clock view back * Formatting * Select browser language for authentication dialog Make authentication dialog bigger to suit for other languages. * Update hashauth.js * Update hashauth.js * Update hashauth.js * Update hashauth.js * Select language from localStorage And get suitable language for the very first auth dialog (before the settings were read from server or user can select language in the configuration) * remove extra `/ ` from clockview, otherwise bundle will not load and search for domain `bundle` fixes #4860 (review) * remove .npmignore for now. should be merged in seperated PR * small fixes
* Updated german Languague for #4851 * added new translations
…ervers (and update npm dependencies) (#4915) * upgrade minimed-connect-to-nightscout to 1.30to fix GuardianConnect for US servers, see mddub/minimed-connect-to-nightscout#13 * npm update to fix security issue fixes https://nodesecurity.io/advisories/1118 (Arbitrary Code Execution in eslint-utils * update to minimed-connect-to-nightscout 1.3.1 * fix typo and make more clear we don't release with insecure dependencies
@@ -738,7 +738,6 @@ daytoday.report = function report_daytoday (datastorage, sorteddaystoshow, optio | |||
var label = ' ' + treatment.carbs + ' g'; | |||
if (treatment.protein) label += ' / ' + treatment.protein + ' g'; | |||
if (treatment.fat) label += ' / ' + treatment.fat + ' g'; | |||
label += ' (' + client.utils.toFixedMin((treatment.carbs / ic), 2) + 'U)'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small cleanup missing - with this gone, the ic variable is unused
cgm-remote-monitor/lib/report_plugins/daytoday.js
737:13 error 'ic' is assigned a value but never used no-unused-vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm not able to test the mmconnect changes, to would be great to get someone who runs that to verify things work with dev
I have noticed some cosmetic issues - on the dev branch there a 3 unit test failing (not ok).
Besides these I noticed no problems (I was unable to test Medtronic GuardianConnect) |
We updated to the dev branch this evening. So far, everything appears to operating correctly for us using OpenAPS and Lookout. It seemed to take noticeably longer to load than it used to. I have several npm tests failing on my local development environment, but the failures appear to be issues with the test, not the operational functionality. |
* Add tap-to-show close buttons * oops, small typos * remove unused class * Add state management to the clock close button hiding
`/api-docs/` seems to be the correct path for the swagger UI. - change `/api-docs.html` reference to `/api-docs/` - also change `/api-docs` to `/api-docs/` as it is more exact
…owsers (tested with iOS 9) (#4932)
* Rewording the "store hash" label (Nobody in the public knows what a "hash" is; this setting is constantly misunderstood.) * Update languge.js to match
* (bluefox) add npmignore * Make it runnable as npm package * (bluefox) use absolute path for static folder * Allow start not only from cgm-remote-monitor * (bluefox) add polling option to make it possible the communication without socket.io * 0.12.3-2 Allow slow communication without socket.io * (bluefox) fix errors * (bluefox) fix clock with authentication * (bluefox) fix clock * fix time * Formatting * Fix clock if authentication is enabled Add .npmignore file * Add time to clock view back * Formatting * Fix authentication dialog Take browser language for auth dialog * Select browser language for authentication dialog Make authentication dialog bigger to suit for other languages. * Update hashauth.js * Update hashauth.js * Update hashauth.js * Update hashauth.js * (bluefox) fix chart if no latestSGV defined * Select language from localStorage And get suitable language for the very first auth dialog (before the settings were read from server or user can select language in the configuration) * Fix language selection * Charts were fixed if no latestSGV value found HTML formatting for "TDD average" and so on * Remove .npmignore * Some code formatting. No relevant changes * Show "-?-" in clock mode if no measured value found. * Small CSS Formatting
Release notes draft: Nightscout 0.12.4
Contributor thanks (in no particular order) to this release go to @Erin879, @GermanBluefox, @PieterGit, @PetrOndrusek, @jpcunningh, @codacy-bot, @bassettb, @ireneusz-ptak, @unsoluble, @herzogmedia, @aviau, @apanasef & @sulkaharo |
Can all of you please help test current dev and report if it works for you? I would like to release a patch release at the end of august if nothing pops up. Main fix is to be able to use Medtronic GuardianConnect in the US. If there is stuff that really needs to be merged in 0.12.4, please speak up now.
TODO: draft up release notes.
Please report success or issues with the upcoming 0.12.4 release here.