More Japanese #4150
More Japanese #4150
Conversation
Trying to add an additional update. Having issues with the process. Hopefully I got it this time!
|
@LuminaryXion do you want to be a maintainer for the Japanese language, if so please PR https://github.com/nightscout/cgm-remote-monitor/blob/dev/CONTRIBUTING.md#translators |
|
Hi! I've added myself as a Japanese contributor. Hopefully I got it right. :) |
|
resolved the conflicts. Should be good to go now! |
|
@PieterGit Hi Pieter! Is this mergable yet? Thank you! |
|
@LuminaryXion You changed some whitespacing, which does not look good on first sight. Please make sure https://github.com/nightscout/cgm-remote-monitor/pull/4150/files only lists japanse fixes and don't make changes to the whitespacing |
|
@LuminaryXion can you have a look at this in the coming days. I would like to work on #4209 and then all translations must be merged to dev first. Otherwise you need to convert the new translations to JSON instead of that I can do that with a script for you. |
|
Hi @PieterGit I found what you were talking about. Fixed it- have a look now. :) |
I see what you mean. Fixed it. :)
|
@LuminaryXion You fixed a couple, but not all. Please check that your IDE or editor does not insert You can check that https://github.com/nightscout/cgm-remote-monitor/pull/4150/files only should show Japanese additions and not spacing changes to other lines. If you don't fix this, the Git history for those lines will be wrong and will tell people you changed those lines. |
|
Ok, I found an easy-ish way to manually put it back and did so. Looks all good to me now. Sorry for the trouble! My OCD kicked in and tried to help. xD LMK if anything else. :) |
|
LGTM. Merging to |
Trying to add an additional update. Having issues with the process. Hopefully I got it this time!