Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG dimension fix #2894

Merged
merged 1 commit into from
Oct 13, 2017
Merged

SVG dimension fix #2894

merged 1 commit into from
Oct 13, 2017

Conversation

unsoluble
Copy link
Contributor

Somehow the NONE.svg ended up with an incorrect rectangle shape; fixed
to match the aspect ratio of the other symbols.

Somehow the NONE.svg ended up with an incorrect rectangle shape; fixed
to match the aspect ratio of the other symbols.
@sulkaharo
Copy link
Member

How did this manifest itself on the site? As in - what does this fix? :)

@unsoluble
Copy link
Contributor Author

Hah, sorry, probably should have been more specific in the commit. This is one of the trend-arrow images used by the /clock-color view (and potentially other views in the future). It's an SVG rectangle, and its dimensions were causing it to fill the enclosing block, instead of staying in proportion to the other images. :)

@sulkaharo sulkaharo merged commit 4e2e871 into nightscout:dev Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants