decrease timeouts to detect regressions faster in future #2800
Conversation
…ng to 25 sec.
```
not ok 1 admintools "before all" hook
Error: timeout of 20000ms exceeded. Ensure the done() callback is being called in this test.
at tests/admintools.test.js:177:7
at Object.done (node_modules/benv/index.js:32:21)
at process.nextTick (node_modules/jsdom/lib/old-api.js:347:18)
at _combinedTickCallback (internal/process/next_tick.js:131:7)
at process._tickCallback (internal/process/next_tick.js:180:9)
not ok 203 Profile editor "before each" hook for "should produce some html"
Error: timeout of 20000ms exceeded. Ensure the done() callback is being called in this test.
at tests/fixtures/headless.js:160:7
at Object.module.exports.setup (node_modules/benv/index.js:24:56)
at Function.init [as setup] (tests/fixtures/headless.js:16:10)
at Context.<anonymous> (tests/profileeditor.test.js:94:14)
```
|
Summary of changes: Following tests need more than 5 sec not ok 1 admintools "before all" hook ==> Works with 25 sec not ok 66 client "before each" hook for "open careportal, and enter a treatment" ==> Works with 25 sec not ok 101 hashauth "before each" hook for "should make module unauthorized" ==> Works with 40 sec not ok 179 pluginbase "before each" hook for "does stuff" ==> Works with 25 sec not ok 204 Profile editor "before each" hook for "should produce some html" ==> Works with 40 sec |
|
@sulkaharo : can you merge to dev? I think this is a stable configuration for the tests. |
|
I noticed all tests fail on the callback, and fail at |
|
Just had the build fail due to a timeout with the longer timeouts, so not merging yet - we do need to find out why the timeouts happen in Travis :( |
|
@sulkaharo : What test did fail in that case? Is there some kind of way of to a different initialization? My nodejs/benv skills are not sufficient for solving that. See https://github.com/nightscout/cgm-remote-monitor/blob/dev/tests/fixtures/headless.js#L18 |
…ote-monitor into travis_improve Update to nightscout 0.10.1 and upgrade nodejs to 8.7.0 and npm update See PR: nightscout#2967
…o 30 sec., just to be sure. I seem to work once with Node 8.7.0, but the test did a timeout once on Node 8.5.0 on Travis.
|
@sulkaharo : I updated this branch to Node 8.7.0 (PR #2800 ). This seems to work fine. To minimize travis errors I upped careportal.test.js and pluginbase.test.js to 30 seconds. Please review and merge to dev (once Azure supports 8.7.0+) |
``` not ok 188 pluginbase "before each" hook for "does stuff" Error: timeout of 30000ms exceeded. Ensure the done() callback is being called in this test. ```
Reverts increasing timeouts. I think these timeouts are enough to make a succesfull build on Travis CI.