Alexa translations #2707
Alexa translations #2707
Conversation
|
Could anybody approve this pull request or let me know if there is anything not right? |
| var response = 'Unable to determine current basal'; | ||
| var preamble = ''; | ||
| if (basalValue.treatment) { | ||
| preamble = (slots && slots.pwd && slots.pwd.value) ? translate('alexaPreamble3person', { |
There was a problem hiding this comment.
Will these work even in the non-Alexa use-case?
|
Hi! Sorry for the extremely long delay. :( I'll pull this soon to test. Can you check this all works fine with the latest dev, I recently PRd in fairly significant changes. |
|
After merging current DEV the unit tests don't work anymore. :-( |
|
Ah yes, sorry. :( I know there's one more I broke with the latest PR, a few are broken for unknown reasons. If you have time to help debug, that'd be super awesome. |
|
Hi
I tried to check out what the problem might be. However, running the tests
locally there are different tests failing than on travis, and those not
working on travis do work locally.
Don't know how to help.
Do you have any suggestions? I'm using node 7.9 locally.
Best regards,
Tanja
…On Fri, Aug 25, 2017 at 7:41 PM, Sulka Haro ***@***.***> wrote:
Ah yes, sorry. :( I know there's one more I broke with the latest PR, a
few are broken for unknown reasons. If you have time to help debug, that'd
be super awesome.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2707 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHD5vtwaEFV5573RAdIjHJ0-zH_QgQlAks5sbwdkgaJpZM4OjITh>
.
|
|
Do you have Mongo running? If the tests can connect to a local Mongo, you should be able to reproduce the test results as is. |
|
No wait, looks like some tests time out in Travis, which is strange. Taking a look. |
…into alexaTranslations
|
Sorry to come back so late. Couldn't make it this week... |
The alexa response was hardcoded in english texts so far. I changed this so translations can be added to support alexa speaking different languages.