Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Blood Sugar" metric/invocation to Alexa Plugin #4168

Closed
haspden opened this issue Dec 30, 2018 · 7 comments
Closed

Add "Blood Sugar" metric/invocation to Alexa Plugin #4168

haspden opened this issue Dec 30, 2018 · 7 comments

Comments

@haspden
Copy link

haspden commented Dec 30, 2018

In the UK we use the words Blood Sugar often rather than Blood Glucose. It would be nice if we could add "Blood Sugar" to the list of questions we could ask.

Thanks

Henry

@unsoluble
Copy link
Contributor

Since building the skill currently involves manually pasting in all the syntax anyway, is probably reasonable to leave custom dialect tweaks like this to the end user for now.

@haspden
Copy link
Author

haspden commented Dec 31, 2018

Well I don't think it disadvantages anybody so would be nice to have a universal Alexa integration that works for everyone. This after all is about making these systems accessible ...

I'll take a look at adding "Blood Sugar" and Sugar Levels" etc to it tomorrow or Tuesday and post an update request to alexa plugin files to be reviewed once done.

If anybody has anything else they thing should be added in terms of questions just shout up here

@unsoluble
Copy link
Contributor

Certainly no harm in it, if you want to do up a PR. Just can imagine it getting out of hand if we start pre-loading it with all conceivable local variations, without maybe re-architecting the thing from the outset with proper language support. But probably nobody's going to do that any time soon, so go for it. :)

@PieterGit
Copy link
Contributor

PieterGit commented Jan 5, 2019

@haspden Of course univeral Alexa integration is nice. Even nicer is: universal Alexa and Google Home and 'fill in some other speech solution' integration.

@unsoluble is right that there are some serious issue with the current Alexa implementation. That's why several Alexa PR's are postponed until 0.12 for now. Please browse the issues/PR's for more information on the open Alexa/Google Home issues.

First problem is to find somebody who want to take ownership of the Alexa plugin code, currently
https://github.com/nightscout/cgm-remote-monitor/blob/dev/CONTRIBUTING.md#plugin-contributors
listst none, not even people who volunteer to test stuff.

Second problem is that Alexa was the first, but Google Home is second, and we also have a universal speech plugin. These different code plugins must share some common code and we must make sure not to end up in a complete different implementation for each speech device. See #4035 (review) for some of the remarks of @sulkaharo which also apply to the Alexa codebase.

Core developers (like me and @sulkaharo) are more than welcome to help get Alexa and Google Home integration with Nightscout into shape, but that needs some effort by others too. We have found several parts of the codebase that needs serious attention before going forward. The alexa plugin is certainly one of them.

@PieterGit PieterGit added this to the 0.12.0 milestone Jan 5, 2019
@many7695
Copy link

I have been using alexa
https://github.com/nightscout/cgm-remote-monitor/blob/master/lib/plugins/alexa-plugin.md
It does work mostly, I have my reading in mmol, alexa gives mr my BG in mmol, but when asking for my ar2 forecast it gives my readings in mg. Any ideas how to fix it

@unsoluble
Copy link
Contributor

@many7695 Ticketed that separately here: #4214

@sulkaharo sulkaharo mentioned this issue Feb 7, 2019
sulkaharo added a commit that referenced this issue Feb 7, 2019
Draft release notes for upcoming 0.11 release (currently release candidate phase).

# Changes

Over 360 commits, 89 files changed, +8,428 / −6,569 lines of changes (full list of changes here: 
https://github.com/nightscout/cgm-remote-monitor/pull/4022/commits )

## New features
- Fully secure by default out of the box.  Unsecure access via http is not allowed anymore by default. This might force you to re-authenticate with your `API_SECRET` or token if you were using unsecure access. (@PieterGit )
- No outdated packages with vulnerabilities are being used anymore (@PieterGit ) 
- Add Week to Week report (@jpcunningh, #4123 ) 
- Add Loopalyzer report to analyse looping. Visualize your loop (@lixgbg, #3629 #4235 )
- Add predictions support to Day to Day report (@lixgbg, #3179 )
- Add cgm sensor stop to Careportal (@jpcunningh, #4060)

## Removed features
- remove `mqtt` module, because it had a security issue and was not used
- remove `sgvdata`  module, because it had a security issue, added a lot of complexity and wasn't needed (@PieterGit ). Replacement implementation for CSV and TSV export (@sulkaharo ).

## Improvements
- Fix MongoDB database insert handling. Log error on inserts and don't crash in case the MongoDB disk is full or MongoDB quota is reached (@sulkaharo and @jpcunningh)
- Upgrade packages to recent version, fixing all known security issues with dependencies (@PieterGit)
- Redirect redirect HTTP to HTTPS and implement HSTS (@jweismann, @PieterGit, #4044 and #4010	and #4253 )
- Technical improvement: Migrate from `uglify-js` to `terser-webpack-plugin` (@PieterGit)
- Streamlined Heroku deployment template with more descriptive text and more appropriate defaults for new users (@unsoluble, #4116 )

## Bug fixes
- Fix CGM voltageb battery warning level to match xDrip+ (@jpcunningh, #3954 )
- Fix daylight saving and reloading bug in profile editor, (@DigitalDan1, @Kywalh #4029 and #4074 )
- Reduce the amount of Profile Switch treatments being loaded to fix UI slowdown and Nightscout home screen losing AAPS data from >3 hours ago, (@sulkaharo, @vickster1, #4055 )
- Upgrade to [share2nightscout 0.2.0](https://github.com/nightscout/share2nightscout-bridge/releases/tag/0.2.0). Prevent Nightscout server crashes in case Dexcom server does not respond (@PieterGit, @veryfancy)
- Fix UI so pills are updated immediately after new data is loaded (@sulkaharo)
- Fixes to If-Modified-Since HTTP header handling for BG data (@sulkaharo)

## Documentation and language updates
- Language updates for Danish, Dutch, German, Hebrew, Norwegian, Russian 
- New languages: Japanese, Turkish
- Update Alexa documentation. Note that some Alexa improvements are postponed to Nightscout 0.12 because the Alexa plugin needs refactoring, see #4168 (comment)
- Update IFTTT maker-setup.md docs (@Dave9111, @unsoluble, #4206 )
- Updated various docs, including [CONTRIBUTING](https://github.com/nightscout/cgm-remote-monitor/blob/dev/CONTRIBUTING.md) documentation

# Upgrade notes
- We only allow Nightscout to start with a secure Node JS. 
  - Latest Node 8 LTS (8.15.0 or later) and Latest Node 10 LTS (10.15.1 or later) are recommended and supported. 
  - Latest Node version on Azure (currently 10.14.0) is tolerated, but not recommended
  - Other versions will not start 
- The [rawbg](https://github.com/nightscout/cgm-remote-monitor#rawbg-raw-bg) settings are converted to a single setting tri-state variable.
- We improved security and added several new environment variables such as [INSECURE_USE_HTTP and SECURE_HSTS_HEADER](https://github.com/nightscout/cgm-remote-monitor/#predefined-values-for-your-server-settings-optional)
  - Your site redirects to https by default. If you don't want that or use a Nginx or Apache proxy, set `INSECURE_USE_HTTP` to `true`.
  - We enabled [HTTP Strict Transport Security (HSTS)](https://en.wikipedia.org/wiki/HTTP_Strict_Transport_Security) headers by default, settings `SECURE_HSTS_HEADER` and `SECURE_HSTS_HEADER_*`

## Upgrade notes for Azure users

We recommend Azure users consider migrating their hosting to Heroku, as we've observed Heroku users have significantly less issues with having their sites work reliably. If you want to continue using Azure, change the following configuration variables in Azure before updating to the latest Nightscout version:
```
WEBSITE_NODE_DEFAULT_VERSION=10.14.1
SCM_COMMAND_IDLE_TIMEOUT=300
```

# Install instructions

Install instructions can be found: https://github.com/nightscout/cgm-remote-monitor/blob/master/README.md#install

# Contributors to this release

The release coordination for this release was done by @PieterGit 
We would like to thank the following people for their contribution (in alphabetical order):
@anderser, @apanasef, @balshor, @bewest, @blocklist_twitter, @CaroGo, @cascer1, @cluckj, @danamlewis, @Dave9111, @diabetlum, @herzogmedia, @janrpn, @jasoncalabrese, @jpcunningh, @jweismann, @kenstack, @Kywalh, @lixgbg, @LuminaryXion, @MilosKozak, @mitrei, @PaperT1D, @PieterGit, @unsoluble, @rarneson, @renegadeandy, @scottleibrand, @sulkaharo, @T-o-b-i-a-s, @tynbendad, @unsoluble, @veryfancy, @viq, @wootmasterslick

(if I forgot somebody, please respond)

# TODO

TODO: Translations, Languages with less than 80% will be removed in a future Nightscout version. Currently the following languages are at risk: 
中文(繁體) (zh_tw), Hrvatski (hr), Ελληνικά (el), 한국어 (ko)
See https://gitter.im/nightscout/public?at=5bef2f34de42d46bba766f66

TODO: Fix Codacy errors, https://app.codacy.com/app/Nightscout/cgm-remote-monitor/issues?bid=2452379&filters=W3siaWQiOiJDYXRlZ29yeSIsInZhbHVlcyI6WyJFcnJvciBQcm9uZSJdfV0=

TODO: test dev after all new features are merged for at least two weeks
@PieterGit
Copy link
Contributor

@haspden Closing this issue due to inactivity. Please check #4980 and see if that works for you. If we find people wanting to maintain Alexa codebase this issue, can perhaps be fixed by one of those people. I am not a Alexa user, so can't help you with this.

@PieterGit PieterGit removed this from the 0.12.0 milestone Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants