Overview add Sensitivity OKDialog

[Philoul]

Include for Autosens area the same kind of OKDialog that we have for Basal or IOB
Il allow a shorter string with DynISF and AutoISF below autosens (ISF for Carbs is hidden), And OKDialog improve the understanding with an explicit string.

I also included the possibility to include more information on Variable ISF calculation (don't know for DynISF if it could be usefull to see for ex the different TDD included for ISF calculation or BG contribution, but for AutoISF I think we will be able to include usefull information)

Currently String from APS plugin are not included (I will try to propose a "User Friendly String" for AutoISF, and if possible not a "Dev Friendly String" 😉 )

[olorinmaia]

Thumbs up from me.
For default I think if autosens is enabled it should show in overview. If dynISFsens is enabled autosens should be moved to this pop-up to avoid confusion and lessen the lines in overview.

[MilosKozak]

I'm not sure about this

[Philoul]

I'm not at home this week-end, will check again everything on sunday afternoon 😉.

[sonarcloud]

Quality Gate failed

Failed conditions
10.0% Duplication on New Code (required ≤ 4%)

See analysis details on SonarQube Cloud

[Philoul]

Built with latest commit (without dedicated UiThread), and works fine on my side 😉

[olorinmaia]

This is how overview screen looks now if DynISF and DynTDDSensitivty is enabled. I think it's time to move some information away from the overview screen and into this Sensitivity OKDialog, it will make the overview screen less stretched and we have the possibility to explain more what each number is for.

My suggestion is to always show only one line, and move other information to the OkDialog:

If Dynamic Sensitivity = Enabled

In Overview:
Always show Profile ISF -> DynISF. Example: 6.0 -> 5.5

OKDialog:
Dynamic ISF for SMB algorithm: 5.5
Dynamic ISF for bolus calc and carbs absorption: 5.0
TDD based Sensitivity ratio: 97% (Enabled/Disabled)
Autosens: 100% (Disabled)
Estimated TDD: X

If Dynamic Sensitivity = Disabled

In Overview: (Only show Autosens %)
x%

OKDialog:
Nothing I can think of. (Disable OKDialog)

[olorinmaia]

How it looks with mg/dl

[Philoul]

That's why I think average ISF should be moved to OKDialog...

• this value is not understood alone (without explicit string)
• variation is very slow
• it increases a lot the width of the view

We can also probably adjust ISF rounding value with one decimal for mmol unit and no decimal for mgdl and reduce overall width.

[olorinmaia]

Agreed, "ISF for carbs absorption" isn't a precise name though as it is also used in Bolus calculator BG/Trend calculation.

@MilosKozak @Philoul @vanelsberg @jbr7rr @ga-zelle
What are your thoughts about leaving only one line in Overview and moving everything else to the OKDialog? It's only when Dynamic Sensitivity is enabled that the need for all this information is handy. Why not gather it all in one Dialog box?

For me the DynISF used for SMB algo is most useful to see in Overview without having to click on sensitivity icon. ISF for bolus calc is also visible when opening bolus calc. Gathering all relevant sensitivity numbers in this box provides a better user experience imo, as we can explain them all abit more.

[Philoul]

I like "only one line" with main information visible (AutoSens with OpenAPS SMB, no need to provide OKDialog), Profile and variable ISF Values for DynISF and AutoISF (then Additional info like Avg ISF, Autosens value, ISF detailed info...), could be different with DynISF and AutoISF...

"ISF for Carbs absorption" was a proposal (string short enough to have label and value in one ĺine).
My initial idea was to have an explicit label for avg ISF (not understandable "alone"), but also provide more detailed info on ISF calculation mainly for AutoISF and potentially DynISF too (everything is prepared to be able to include a custom string built within APS algo...)

[ga-zelle]

Yes, one line only. Its content depends on the current plugin or mode. My vote is mostly percentage of final ISF compared to profile value with the exeption of active DynISF where it is shown as absolute value without showing the profile value in overview.

[vanelsberg]

only one line

Have been on OpenSMB (which is also showing this) and found it quite informative as it shows my deviations on ISF from profile and actual ISF calculated? So for me, I'm quite happy with the view as is currently... 🤔

[robertrub]

I find that this corner is overcrowded. Even the last ) can't be seen and it pushes all the other numbers (COB IOB) to the left.

Either we can show one number and tap to have a window with more info (as in IOB) or we have to move around the numbers or/and make them smaller.

Move the AS next to the icon and delete the average in (). It can be seen with a tap in a new window as it is not very useful to have it all the time.

The above screenshots were with AutoISF.

Also, if I'm on OpenSMB with DynISF turned OFF, I don't need to see what my ISF would be if I had DynISF tuned ON... I'd like to get that info after a tap to get detailed info.

[robertrub]

And, the actual situation is not great with the widget either...

[vanelsberg]

And, the actual situation is not great with the widget either...

For me it is showing just fine. Try resizing the widget?
Or else, remove and readd. Widget could be on older cached version?

[vanelsberg]

I find that this corner is overcrowded.

For me, it has value in a sense that I can see what algo is doing and what impact sensitivity has (or would have)?

A -> B (C)
A := ISF value used for algo calculation after adapting for sensitivity
B: = Change according to AutoISF
C: = Original ISF value in profile

(Note that currently Calculator is using C)
Maybe @ga-zelle or @Philoul can add to that?

[robertrub]

Or else, remove and readd. Widget could be on older cached version?

Nope, just deleted the widget and set it up again with the sale result

[robertrub]

A -> B (C)
A := ISF value used for algo calculation after adapting for sensitivity
B: = Change according to AutoISF
C: = Original ISF value in profile

What I need to see all the time is

modified ISF (profile ISF)

A tap on those numbers can give me all the details one can wish for.

Another positif side is that DynISF and AutoISF can have the same screen output.

On the main UI, above the ISF numbers, we can have the AutoSens % and a small icon to show if it is ON or OFF. The on/off information can be given by text color too.

[Philoul]

@vanelsberg

A -> B (C)
A := ISF value used for algo calculation > after adapting for sensitivity
B: = Change according to AutoISF
C: = Original ISF value in profile

It's the proof it cannot remain "As is"

You are a skilled user, knows perfectly well AAPS, but your explains are wrong...
A: = Original ISF value in profile
B: = Change according to AutoISF or DynISF
C: = 24h average ISF value used for Carbs absorption or Calculator.

[vanelsberg]

your explains are wrong.

Ah yes, I see now :-|

It's the proof it cannot remain "As is"
Thinking about the above, I tend to agree on that. So yes.... ;-)

[vanelsberg]

A tap on those numbers can give me all the details one can wish for.

Agree, this could be a valid alternative.
It's just that for some info I need to be able to see in a glance (vs need for taking action to get it)

[vanelsberg]

Nope, just deleted the widget and set it up again with the sale result

That is strange.
For me gadget it is showing just fine on S22 Ultra, S9 Note (lineageOS) and Nokia 5.4

[robertrub]

For me gadget it is showing just fine on S22 Ultra, S9 Note (lineageOS) and Nokia 5.4

[ga-zelle]

Or else, remove and readd. Widget could be on older cached version?

Nope, just deleted the widget and set it up again with the sale result

I had a similar squeeze problem where a whole line was missing. Solved by reducing the general font size of the phone.

[robertrub]

Yes, if I make the font smaller (2nd position), it fits. But, I'm only using the third position out of 8 possible and I'm 62 y.o. 😉

[Philoul]

An idea this morning for single line short info in Overview:

Icon above AS value has a double Arrow (with or without X) according to AS disabled or enabled.
This icon can be a bit more dynamic:

• no change when 100% (should be most of the time)
• Up arrow only (with or without X) when percentage is above 100%
• Down arrow only (with or without X) when percentage is below 100%

OpenAPS AMA or SMB:
AS: xx% (consistant with dynamic icon above)
or
Alg: xx% (consistant with dynamic icon above)
Note: I still have to analyze code to understand the difference between AS and Alg % and when these values are not the same 🤔

In OKDialog (TBC if we need it or not)

• explicit label and percentage for AS
• explicit label and percentage for Alg

DynISF or AutoISF:
One line with ISF value (and dynamic icon above for AS).

• I think we can keep xxx->yyy (same as current master)

In OKDialog:

• AS/Alg values (single or 2 lines with explicit label)
• Average ISF (with explicit short label)
• Then, according to selected algo (DynISF or AutoISF), a user friendly string to explain ISF calculation (to be discuss)

Widget is a side effect of the too long string and should be fixed if we reduce the size 😉

[ga-zelle]

Regarding the Alg: %% (or middle row if present) I think this comes from TT changing sensitivity