enable storybook to deliver statics from hapijs server #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natterstefan
force-pushed
the
feature/storybook-statics
branch
from
68054a3 to
b47b945
Compare
natterstefan
force-pushed
the
feature/storybook-statics
branch
from
b47b945 to
bdf4a49
Compare
lukasender
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
npm run build:storybook) with proper static files handling. We'll have to find a workaround/solution for this first. I will need to figure out if these two issues help me: Keeping the path for the static directory in building storybookjs/storybook#714 (comment) and [Issue] - Can't load images with build-storybook under "/static" directory storybookjs/storybook#2948.