Skip to content
This repository has been archived by the owner on Jun 6, 2018. It is now read-only.

Generate CheckSum using java.security.MessageDigest #33

Conversation

Ma27
Copy link

@Ma27 Ma27 commented Nov 25, 2017

As discussed in #27

Please note that this is just a WIP, it needs a bit more testing and the docs require an update after that.

This changes allows it to generate the hashes for the JAR's package set
without `nix-prefetch-scripts`, but `java.security.MessageDigest`
instead. In order to achieve this, the following changes have been
applied:

* Replaced old `nix-prefetch-url` invokation in `FindArtifactsOfRepo`
  with `MessageDigest`

* Use `Try[T]` for error handling of the artifact's fetcher.

* Fixed minor working-directory bug in `tests/template-generation`.

* Removed `nix-prefetch-scripts` from `sbtix-tool` closure.

* Fixed `sbtix` package build expression. When `.bat` files are present
  that are non-executable, `wrapProgram` can't create a wrapper. Instead
  `find . -executable` should be used to wrap files in `$out/bin`.

See nightkr#27
@Ma27 Ma27 force-pushed the refactoring/#27/get-rid-of-nix-dependency-for-hash-computations branch from e97349c to 762e1fb Compare May 3, 2018 17:16
@Ma27
Copy link
Author

Ma27 commented May 3, 2018

@teozkr running the builds in tests/ works fine now, however sbt scripted, but this failure can be observed on master as well, so I doubt that it's related to my patch :-)

@Ma27 Ma27 changed the title [WIP] Generate CheckSum using java.security.MessageDigest Generate CheckSum using java.security.MessageDigest May 3, 2018
@nightkr
Copy link
Owner

nightkr commented May 3, 2018

Oh yeah, that's because my old file server's drive died. :/

@Ma27
Copy link
Author

Ma27 commented May 3, 2018

is there anything I can do to help you fixing that or should we rather disable the test temporarily?

@nightkr
Copy link
Owner

nightkr commented May 3, 2018

Probably best to just get it back up again.

@nightkr
Copy link
Owner

nightkr commented May 4, 2018

Deploying a fix now.

@nightkr
Copy link
Owner

nightkr commented May 4, 2018

@Ma27 Things should be working again now. I've requested a rebuild of the PR.

@Ma27
Copy link
Author

Ma27 commented May 5, 2018

first of all thanks a lot for your efforts regarding the private auth test!
Unfortunately the build remains broken (https://travis-ci.org/teozkr/Sbtix/builds/374520996#L4090) and I'm not sufficiently experienced with SBT's private auth to investigate, do you have an idea what went wrong? :-)

@nightkr
Copy link
Owner

nightkr commented May 5, 2018

Note to self: don't play with Nginx after midnight. It should work now.

@Ma27
Copy link
Author

Ma27 commented May 5, 2018

@teozkr yeah I can somehow relate to that 🙈

As the build is green now - could you have a look at the changeset please - as it's some time since I started working on this I'm not 100% sure if the change is sufficient and good enough for merge 😅

@nightkr
Copy link
Owner

nightkr commented May 5, 2018

@Ma27 Looks good to me.

@nightkr nightkr merged commit 07baff0 into nightkr:master May 5, 2018
@Ma27 Ma27 deleted the refactoring/#27/get-rid-of-nix-dependency-for-hash-computations branch May 5, 2018 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants